fix review issues

This commit is contained in:
Adam 2022-08-28 15:47:55 +02:00
parent aa716b5d28
commit 5d43bea6ac
3 changed files with 6 additions and 6 deletions

View file

@ -400,10 +400,10 @@ describe('setup-node', () => {
os.platform = 'linux';
os.arch = 'x64';
inputs['node-version'] = '12';
inputs['node-version'] = '16';
inputs['corepack'] = 'true';
const toolPath = path.normalize('/cache/node/12.16.1/x64');
const toolPath = path.normalize('/cache/node/16.17.0/x64');
findSpy.mockReturnValue(toolPath);
await main.run();

View file

@ -15,7 +15,7 @@ inputs:
description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.'
default: 'false'
corepack:
description: 'Set this option if you want to install the core-pack.'
description: 'Automatically enables corepack'
default: 'false'
registry-url:
description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.'

View file

@ -318,7 +318,7 @@ steps:
- uses: actions/setup-node@v3
with:
node-version: '14.x'
corepack: enable
corepack: true
```
It is recommended to configure `package.json#packageManager` if you want to use it.
@ -327,7 +327,7 @@ e.g.
```json
{
"name": "example",
"packageManager": "pnpm@7.5.2",
"packageManager": "pnpm@7.9.5",
// ...
}
```