diff --git a/__tests__/official-installer.test.ts b/__tests__/official-installer.test.ts index 5061bdf6..6dfac1c9 100644 --- a/__tests__/official-installer.test.ts +++ b/__tests__/official-installer.test.ts @@ -309,7 +309,6 @@ describe('setup-node', () => { expect(logSpy).toHaveBeenCalledWith( 'Not found in manifest. Falling back to download directly from Node' ); - expect(logSpy).toHaveBeenCalledWith('came here undefined'); expect(dlSpy).toHaveBeenCalled(); expect(exSpy).toHaveBeenCalled(); expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`); diff --git a/dist/setup/index.js b/dist/setup/index.js index fdbb66f2..f5b224dd 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -73431,7 +73431,7 @@ var Distributions; Distributions["RC"] = "rc"; })(Distributions || (Distributions = {})); function identifyDistribution(versionSpec) { - let distribution = ''; + let distribution = Distributions.DEFAULT; if (versionSpec.includes(Distributions.NIGHTLY)) { distribution = Distributions.NIGHTLY; } @@ -73441,9 +73441,6 @@ function identifyDistribution(versionSpec) { else if (versionSpec.includes(Distributions.RC)) { distribution = Distributions.RC; } - else { - distribution = Distributions.DEFAULT; - } return distribution; } function getNodejsDistribution(installerOptions) { @@ -73651,7 +73648,6 @@ class OfficialBuilds extends base_distribution_1.default { } if (!toolPath) { const nodeVersions = yield this.getNodejsVersions(); - core.info('came here undefined'); const versions = this.filterVersions(nodeVersions); const evaluatedVersion = this.evaluateVersions(versions); if (!evaluatedVersion) { diff --git a/src/distibutions/installer-factory.ts b/src/distibutions/installer-factory.ts index 56cc0bf8..eccaa2f7 100644 --- a/src/distibutions/installer-factory.ts +++ b/src/distibutions/installer-factory.ts @@ -13,15 +13,13 @@ enum Distributions { } function identifyDistribution(versionSpec: string) { - let distribution = ''; + let distribution = Distributions.DEFAULT; if (versionSpec.includes(Distributions.NIGHTLY)) { distribution = Distributions.NIGHTLY; } else if (versionSpec.includes(Distributions.CANARY)) { distribution = Distributions.CANARY; } else if (versionSpec.includes(Distributions.RC)) { distribution = Distributions.RC; - } else { - distribution = Distributions.DEFAULT; } return distribution; diff --git a/src/distibutions/nightly/nightly_builds.ts b/src/distibutions/nightly/nightly_builds.ts index 48f080d9..91a47d02 100644 --- a/src/distibutions/nightly/nightly_builds.ts +++ b/src/distibutions/nightly/nightly_builds.ts @@ -4,7 +4,7 @@ import * as tc from '@actions/tool-cache'; import semver from 'semver'; import BaseDistribution from '../base-distribution'; -import {INodejs, INodeVersion} from '../base-models'; +import {INodejs} from '../base-models'; export default class NightlyNodejs extends BaseDistribution { constructor(nodeInfo: INodejs) { diff --git a/src/distibutions/official_builds/official_builds.ts b/src/distibutions/official_builds/official_builds.ts index 7ef7b0e7..f655c3b6 100644 --- a/src/distibutions/official_builds/official_builds.ts +++ b/src/distibutions/official_builds/official_builds.ts @@ -108,7 +108,6 @@ export default class OfficialBuilds extends BaseDistribution { if (!toolPath) { const nodeVersions = await this.getNodejsVersions(); - core.info('came here undefined'); const versions = this.filterVersions(nodeVersions); const evaluatedVersion = this.evaluateVersions(versions); if (!evaluatedVersion) { diff --git a/src/distibutions/official_builds/rc/rc_builds.ts b/src/distibutions/official_builds/rc/rc_builds.ts index d6e2d893..666673f4 100644 --- a/src/distibutions/official_builds/rc/rc_builds.ts +++ b/src/distibutions/official_builds/rc/rc_builds.ts @@ -3,7 +3,7 @@ import * as core from '@actions/core'; import * as semver from 'semver'; import BaseDistribution from '../../base-distribution'; -import {INodejs, INodeVersion} from '../../base-models'; +import {INodejs} from '../../base-models'; export default class RcBuild extends BaseDistribution { constructor(nodeInfo: INodejs) { diff --git a/src/distibutions/v8-canary/canary_builds.ts b/src/distibutions/v8-canary/canary_builds.ts index f785456a..a1231cab 100644 --- a/src/distibutions/v8-canary/canary_builds.ts +++ b/src/distibutions/v8-canary/canary_builds.ts @@ -4,7 +4,7 @@ import * as tc from '@actions/tool-cache'; import semver from 'semver'; import BaseDistribution from '../base-distribution'; -import {INodejs, INodeVersion} from '../base-models'; +import {INodejs} from '../base-models'; export default class CanaryBuild extends BaseDistribution { constructor(nodeInfo: INodejs) {