From 3ae89a1d16b4cdd642cac8bf080cfe952c93e278 Mon Sep 17 00:00:00 2001 From: Jacky Zhao Date: Fri, 4 Apr 2025 10:17:57 -0700 Subject: [PATCH] fix(search): make closest sidebar z-index adjustment optional (closes #1905) --- quartz/components/scripts/search.inline.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/quartz/components/scripts/search.inline.ts b/quartz/components/scripts/search.inline.ts index 1f4c009..d95f468 100644 --- a/quartz/components/scripts/search.inline.ts +++ b/quartz/components/scripts/search.inline.ts @@ -147,8 +147,7 @@ async function setupSearch(searchElement: Element, currentSlug: FullSlug, data: const container = searchElement.querySelector(".search-container") as HTMLElement if (!container) return - const sidebar = container.closest(".sidebar") as HTMLElement - if (!sidebar) return + const sidebar = container.closest(".sidebar") as HTMLElement | null const searchButton = searchElement.querySelector(".search-button") as HTMLButtonElement if (!searchButton) return @@ -180,7 +179,7 @@ async function setupSearch(searchElement: Element, currentSlug: FullSlug, data: function hideSearch() { container.classList.remove("active") searchBar.value = "" // clear the input when we dismiss the search - sidebar.style.zIndex = "" + if (sidebar) sidebar.style.zIndex = "" removeAllChildren(results) if (preview) { removeAllChildren(preview) @@ -192,7 +191,7 @@ async function setupSearch(searchElement: Element, currentSlug: FullSlug, data: function showSearch(searchTypeNew: SearchType) { searchType = searchTypeNew - sidebar.style.zIndex = "1" + if (sidebar) sidebar.style.zIndex = "1" container.classList.add("active") searchBar.focus() }